12-17-2001, 02:40 PM -
Here are exact instructions to reproduce the inconsistent behaviour I talked about:
Problem 1:
1. Open TLB Settings -> Toolbars: Make a *new* toolbar, then press OK to quit TLB Settings.
2. Open TLB Settings -> Toolbars: Delete the toolbar you just created. Observe that the toolbar is gone (as expected). Then press OK to quit TLB Settings.
3. Open TLB Settings -> Toolbars: The toolbar you just deleted is still there!
4. Unload TLB, or reboot the computer.
5. Observe that the toolbar you deleted is still there.
6. Now delete the toolbar *again*. Now it's finally deleted permanently!
So, if you make a new toolbar by mistake, or just to test the feature, you will have to unload TLB and load it again (or reboot) before you can delete it.
Problem 2:
Open TLB Settings -> Toolbars: Rename an existing toolbar. Then press Activate, and choose 'Yes' in the message box that follows to apply changes. This will not rename the toolbar as expected, but create a copy of this toolbar with the new name. You may have to quit TLB Settings and open it again to see this.
Problem 3:
Open TLB Settings -> Toolbars, choose a toolbar and press Activate. I've not made any changes to the highlighted toolbar, still I get the message 'Do you want to apply changes in this toolbar?', options Yes, No, Cancel. Well, the following happens:
1. I choose 'Cancel' -> nothing happens, as expected.
2. I choose 'Yes' -> the highlighted toolbar is activated, as expected.
3. I choose 'No' -> the highlighted toolbar is activated. Should I expect this? I understand from your previous post that this is the way it should be. But consider what happens when I *do* change the toolbar, the name in this case, before pressing Activate, and choose 'No', then the toolbar is *not* activated. I think this behaviour is confusing, and that you should look into this again. I would suggest the following:
1. Do not ask to apply changes if the user hasn't made any changes to the toolbar settings.
2. When the user *has* made changes, and answeres 'No' to apply changes, abandon the changes before activating the toolbar (yes, *do* activate).
Problem 4:
The directory where the toolbar resides is used as toolbar title. Wouldn't it be more natural to use the toolbar name as title (toolbar name as given in TLB Settings -> Toolbars)?
(Edited by tb at 3:57 pm on Dec. 17, 2001)
Problem 1:
1. Open TLB Settings -> Toolbars: Make a *new* toolbar, then press OK to quit TLB Settings.
2. Open TLB Settings -> Toolbars: Delete the toolbar you just created. Observe that the toolbar is gone (as expected). Then press OK to quit TLB Settings.
3. Open TLB Settings -> Toolbars: The toolbar you just deleted is still there!
4. Unload TLB, or reboot the computer.
5. Observe that the toolbar you deleted is still there.
6. Now delete the toolbar *again*. Now it's finally deleted permanently!
So, if you make a new toolbar by mistake, or just to test the feature, you will have to unload TLB and load it again (or reboot) before you can delete it.
Problem 2:
Open TLB Settings -> Toolbars: Rename an existing toolbar. Then press Activate, and choose 'Yes' in the message box that follows to apply changes. This will not rename the toolbar as expected, but create a copy of this toolbar with the new name. You may have to quit TLB Settings and open it again to see this.
Problem 3:
Open TLB Settings -> Toolbars, choose a toolbar and press Activate. I've not made any changes to the highlighted toolbar, still I get the message 'Do you want to apply changes in this toolbar?', options Yes, No, Cancel. Well, the following happens:
1. I choose 'Cancel' -> nothing happens, as expected.
2. I choose 'Yes' -> the highlighted toolbar is activated, as expected.
3. I choose 'No' -> the highlighted toolbar is activated. Should I expect this? I understand from your previous post that this is the way it should be. But consider what happens when I *do* change the toolbar, the name in this case, before pressing Activate, and choose 'No', then the toolbar is *not* activated. I think this behaviour is confusing, and that you should look into this again. I would suggest the following:
1. Do not ask to apply changes if the user hasn't made any changes to the toolbar settings.
2. When the user *has* made changes, and answeres 'No' to apply changes, abandon the changes before activating the toolbar (yes, *do* activate).
Problem 4:
The directory where the toolbar resides is used as toolbar title. Wouldn't it be more natural to use the toolbar name as title (toolbar name as given in TLB Settings -> Toolbars)?
(Edited by tb at 3:57 pm on Dec. 17, 2001)